Ensure that Uint8ClampedArray is used for image data transfered by getTransfers (PR 9802 follow-up)
#9980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`getTransfers` (PR 9802 follow-up) One of the `QueueOptimizer` cases wasn't updated to use `Uint8ClampedArray`s, which leads to inconsistent image data on the API side (but no actual rendering bugs, as far as I can tell). To prevent future errors, a non-production/test-only `assert` was added to ensure that the relevant image data only uses `Uint8ClampedArray`s.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8147a30f60cb032/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f001868d8d95498/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f001868d8d95498/output.txt Total script time: 30.01 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8147a30f60cb032/output.txt Total script time: 36.45 mins
|
timvandermeij
approved these changes
Aug 16, 2018
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the
QueueOptimizercases wasn't updated to useUint8ClampedArrays, which leads to inconsistent image data on the API side (but no actual rendering bugs, as far as I can tell).To prevent future errors, a non-production/test-only
assertwas added to ensure that the relevant image data only usesUint8ClampedArrays.